Tim Armstrong has posted comments on this change. Change subject: IMPALA-3762: Download Python requirements before they are needed. ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3426/1/buildall.sh File buildall.sh: Line 244: $IMPALA_HOME/infra/python/deps/download_requirements I think the one thing I'm concerned about here is that pip_download.py will fail if it can't access pip metadata over the internet. I'm not sure if pip itself can succeed if it doesn't have an internet connection to phone home. This is mainly annoying since it would block developing offline. Maybe we should just wrap this in an if statement, then issue a warning and continue if it fails? -- To view, visit http://gerrit.cloudera.org:8080/3426 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I986f6712099d23d452b40f5443ac78722b8a58f0 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Jim Apple <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
