David Knupp has posted comments on this change. Change subject: IMPALA-1683: Allow REFRESH on a single partition ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/3385/2/tests/metadata/test_refresh_partition.py File tests/metadata/test_refresh_partition.py: PS2, Line 48: ImpalaDbWrapper This is a nicely-implemented context manager for setting up and tearing down databases for your tests, but it appears to duplicate functionality that is already provided by the unique_database pytest fixture (which you also use.) It would be better to stick with just one method for setting up databases, and I think the preferred choice would be to use the fixture. -- To view, visit http://gerrit.cloudera.org:8080/3385 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4bf5dd630f2e175be5800187bbf9337c91f82bd8 Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-HasComments: Yes
