Tim Armstrong has posted comments on this change. Change subject: IMPALA-3674: Lazy materialization of LLVM module bitcode. ......................................................................
Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/3220/4/be/src/codegen/llvm-codegen.cc File be/src/codegen/llvm-codegen.cc: Line 249: bool error = Linker::linkModules(*module_, std::move(new_module)); After mucking around for a while with my patch that usings linkModule() for extensively, I'm pretty sure that using the linker with lazily-loaded modules isn't safe: it's not really supported or tested. Line 782: module_->materializeAll(); I noticed that an error code is ignored here while I was rebasing onto the patch. -- To view, visit http://gerrit.cloudera.org:8080/3220 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ed7862fc5e86005ecea83fa2ceb489e737d66b2 Gerrit-PatchSet: 4 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Mostafa Mokhtar <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
