Dan Hecht has posted comments on this change.

Change subject: IMPALA-1619: Support 64-bit allocations.
......................................................................


Patch Set 7:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/2781/7/be/src/exec/delimited-text-parser.cc
File be/src/exec/delimited-text-parser.cc:

Line 123:           row_end_locations, field_locations, num_tuples, num_fields, 
next_column_start));
> Not really. Is there any recommendation on the benchmark to run ?
Just do a single node benchmark where you scan a text table large enough to get 
a consistent timing for, where the query time is dominated by the scan.


-- 
To view, visit http://gerrit.cloudera.org:8080/2781
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7ed28083d809a86d801a9c063a0aa32c50d32b20
Gerrit-PatchSet: 7
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Michael Ho <[email protected]>
Gerrit-Reviewer: Dan Hecht <[email protected]>
Gerrit-Reviewer: Michael Ho <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-HasComments: Yes

Reply via email to