Henry Robinson has posted comments on this change. Change subject: IMPALA-3798: Disable per-split filtering for sequence-based scanners ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/3524/1//COMMIT_MSG Commit Message: PS1, Line 15: num_files_queued_ > num_unqueued_files_ Done PS1, Line 19: This bug therefore only shows up when there is >1 scan range per file. > I'm not sure that's true. Seems it can happen with 1 scan range per file as The scan-range-filter path will do most of the work of RangeComplete() for the header split, which means that progress_ will get updated, which is sufficient to exit the scanner thread loop. -- To view, visit http://gerrit.cloudera.org:8080/3524 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4770dd77fd4258c24115d72b572c727b770bd75d Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Henry Robinson <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-HasComments: Yes
