Lars Volker has submitted this change and it was merged. Change subject: IMPALA-3800: Python 2.6 support for collect_minidumps.py ......................................................................
IMPALA-3800: Python 2.6 support for collect_minidumps.py Python 2.6 is the default python version shipped with CentOS 6.6 and the minidump collection script needs to run there, too. However, the tarfile library version shipped with python 2.6 does not support using TarFile objects as context managers. This change wraps the usage of tarfile.TarFile in contextlib.closing to support python 2.6, too. Testing: I verified that this script runs with python 2.7 on testdata generated using the generate_minidump_collection_testdata.py script. I also copied an updated version to a CentOS 6.6 cluster and verified that the problem is resolved there. Change-Id: Ic9028626fa829ff7571d2a731c2fcd7e15e2ce36 Reviewed-on: http://gerrit.cloudera.org:8080/3525 Reviewed-by: Michael Brown <[email protected]> Reviewed-by: Taras Bobrovytsky <[email protected]> Reviewed-by: Dan Hecht <[email protected]> Tested-by: Lars Volker <[email protected]> --- M bin/collect_minidumps.py 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Michael Brown: Looks good to me, but someone else must approve Taras Bobrovytsky: Looks good to me, approved Lars Volker: Verified Dan Hecht: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/3525 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic9028626fa829ff7571d2a731c2fcd7e15e2ce36 Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-2.6.0_5.8.0 Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]>
