David Knupp has posted comments on this change. Change subject: IMPALA-3225: Add script to push from gerrit to ASF ......................................................................
Patch Set 2: Code-Review+2 (1 comment) Carrying forward the +2 from Tim. http://gerrit.cloudera.org:8080/#/c/3468/1/bin/push_to_asf.py File bin/push_to_asf.py: PS1, Line 115: ['git', 'config', '--local', '--get', 'remote.apache.url']).strip() : except subprocess.CalledProcessError: > Valid questions/concerns, though I don't think it's worth spending too much Sure, adding a TODO seems like a reasonable interim step. -- To view, visit http://gerrit.cloudera.org:8080/3468 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I15de939acc4b08a8f01511fffcb6ab1743d09c01 Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Matthew Jacobs <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
