Sailesh Mukil has posted comments on this change. Change subject: IMPALA-2767: Web UI call to force expire sessions ......................................................................
Patch Set 4: Code-Review+2 (5 comments) Carry +2. Rebase. Make final fixes according to CR. Will run a private build and post the results here before merging. http://gerrit.cloudera.org:8080/#/c/3555/2/be/src/service/impala-http-handler.cc File be/src/service/impala-http-handler.cc: PS2, Line 67: : void ImpalaHttpHandler::RegisterHandlers(Webserver* webserver) { : DCHECK(webserver != NULL); : : webserver->RegisterUrlCallback("/hadoop-varz", "hadoop-varz.tmpl", : MakeCallback(this, &ImpalaHttpHandler::HadoopVarzHandler)); : : webserver->RegisterUrlCallback("/queries", "queries.tmpl", : > how about refactoring this and ParseQueryId into a single method that takes Done PS2, Line 103: alse, true, ar > close_session? Done PS2, Line 104: > CloseSessionHandler? Done Line 184: Value error(parse_status.GetDetail().c_str(), document->GetAllocator()); > nit: add the session ID here? Done http://gerrit.cloudera.org:8080/#/c/3555/2/be/src/service/impala-http-handler.h File be/src/service/impala-http-handler.h: Line 95: /// Closes an active session with a client. > Add a comment, like the method above. Done -- To view, visit http://gerrit.cloudera.org:8080/3555 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia2639993502a6deb5c24c3f1d055d82ade05ff67 Gerrit-PatchSet: 4 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: Yes
