Tim Armstrong has posted comments on this change. Change subject: IMPALA-1619: Support 64-bit allocations. ......................................................................
Patch Set 1: Code-Review+1 (3 comments) http://gerrit.cloudera.org:8080/#/c/3575/1/testdata/compressed_formats/compressed_payload.snap File testdata/compressed_formats/compressed_payload.snap: Can you add a README that describes the file? http://gerrit.cloudera.org:8080/#/c/3575/1/tests/query_test/test_compressed_formats.py File tests/query_test/test_compressed_formats.py: PS1, Line 190: hdfs_cat I think you may want to call .wait() ion this. I'm not sure if the resources are released otherwise. Line 193: for line in hdfs_cat.stdout: Why not compressed_payload = hdfs_cat.stdout.read() -- To view, visit http://gerrit.cloudera.org:8080/3575 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic1af1564953ac02aca2728646973199381c86e5f Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
