Henry Robinson has posted comments on this change. Change subject: IMPALA-3442: Replace '> >' with '>>' in template decls ......................................................................
Patch Set 1: Hm, looks just fine to me. Do you think it might be worth investigating an upgrade for your Emacs C++ mode? 24.3 is almost three years old, and it clearly has bugs handling C++11 (a quick search shows lots of complaints about C++11 support in the 24.X timeframe). Since we're moving to C++11 across the codebase, it's probably a good idea to make sure your tools support it properly as well. Plus we probably don't want to prescribe to contributors that they *have* to write it as "vector<pair<a,b> >". -- To view, visit http://gerrit.cloudera.org:8080/3562 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9b27dfbda791ec6730c329c91bed015887a5e27c Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Henry Robinson <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-HasComments: No
