Huaisi Xu has posted comments on this change.

Change subject: IMPALA-3711: Remove unnecessary privilege checks in 
getDbsMetadata()
......................................................................


Patch Set 21:

> > It looks like GVM was run against the commit hash from patch set
 > > 20, which is why you got the +1 on it, instead of patch set 21
 > > along with a submit.
 > >
 > > http://sandbox.jenkins.cloudera.com/job/impala-external-gerrit-verify-merge/2575/
 > 
 > I cannot access sandbox.jenkins.cloudera.com/* now. but according
 > to my shell history, I submitted two gvms. both of them were
 > against 'refs/changes/71/3371/21'. Did I miss anything?
 > 
 > GVM messages:
 > huaisi@huaisi-Desktop:~/Impala$ gerrit-verify-merge
 > Running: ssh -p 29418 [email protected] gerrit query 
 > --format JSON --current-patch-set c1a1762d00c14fa9d623a1d85918fbd0e1dc3c77
 > Parsing gerrit refspec from commit: c1a1762d00c14fa9d623a1d85918fbd0e1dc3c77
 > Launching Jenkins Job using GERRIT_REF_SPEC: 'refs/changes/71/3371/21'
 > TARGET_BRANCH: 'cdh5-trunk'
 > Job submitted successfully. E-mail will be sent to:
 > [email protected] upon completion
 > 
 > Not sure why this failed to get merged by gvm.

>From the message I got in shell, it ran for patch 21. Not sure why it 
>commented for patch 20.

-- 
To view, visit http://gerrit.cloudera.org:8080/3371
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I17d8c5b9fb12483e4b01b819fba48b6849311a14
Gerrit-PatchSet: 21
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Huaisi Xu <[email protected]>
Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]>
Gerrit-Reviewer: Henry Robinson <[email protected]>
Gerrit-Reviewer: Huaisi Xu <[email protected]>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Michael Brown <[email protected]>
Gerrit-HasComments: No

Reply via email to