Tim Armstrong has posted comments on this change. Change subject: IMPALA-2033: Netezza compatibility functions quote_ident ......................................................................
Patch Set 2: (2 comments) Unfortunately this is a bit of a tricky one since we don't have a live system to compare against (there was a previous attempt to implement this that got abandoned). Still have a couple of comments. http://gerrit.cloudera.org:8080/#/c/3263/2/be/src/exprs/expr-test.cc File be/src/exprs/expr-test.cc: PS2, Line 1952: ABC > So should I change it, Netezza converts unquoted lower-case to upper-case, Sorry for the slow response, this got stuck at the bottom of my inbox. I think so. I'm not an expert on netezza functions, but the docs say that "Regular identifiers are case insensitive and are stored in the database in upper-case. " http://gerrit.cloudera.org:8080/#/c/3263/2/be/src/exprs/string-functions-ir.cc File be/src/exprs/string-functions-ir.cc: PS2, Line 761: all_lowercase > I was confused why the variable is called 'all_lowercase' when it may conta Could you respond to this comment? -- To view, visit http://gerrit.cloudera.org:8080/3263 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idbac4cd10fe08a6bd4871a03ba3b5f2c20fa8ee1 Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Shirish Gajera <[email protected]> Gerrit-Reviewer: Shirish Gajera <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
