Tim Armstrong has posted comments on this change. Change subject: IMPALA-2885: Stores ScannerContext::Stream objects in ScannerContext's own object pool ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3590/1/be/src/exec/scanner-context.h File be/src/exec/scanner-context.h: Line 295: std::vector<Stream*> streams_; Maybe it's simpler to just make these scoped_ptrs or unique_ptrs? Makes the ownership more explicit. -- To view, visit http://gerrit.cloudera.org:8080/3590 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic5440d414ecc0ca19676c553275aeb85231d6045 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
