Tim Armstrong has posted comments on this change. Change subject: IMPALA-3677: Write minidump on SIGUSR1 ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/3312/3/tests/custom_cluster/test_breakpad.py File tests/custom_cluster/test_breakpad.py: PS3, Line 149: time.sleep(5) > I agree with you, this is not optimal. For killing the processes we already I think David makes a good point. I think it's less effort to add the retry loop now than it is to debug a flaky test in the future, especially if we run into problems with code coverage. -- To view, visit http://gerrit.cloudera.org:8080/3312 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I40149e48e391451de21a5c8bda18e2307fc89513 Gerrit-PatchSet: 3 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
