Marcel Kornacker has posted comments on this change. Change subject: IMPALA-3734: C++11 - Replace boost:shared_ptr with std:: equivalent ......................................................................
Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/3563/3/be/src/runtime/test-env.cc File be/src/runtime/test-env.cc: Line 23: using boost::scoped_ptr; why? http://gerrit.cloudera.org:8080/#/c/3563/3/be/src/service/impala-hs2-server.cc File be/src/service/impala-hs2-server.cc: Line 593: shared_ptr<SessionState> state = make_shared<SessionState>(); does this have any advantage over the c'tor? http://gerrit.cloudera.org:8080/#/c/3563/3/be/src/transport/TSaslServerTransport.h File be/src/transport/TSaslServerTransport.h: Line 178: TransportMap transportMap_; needed? -- To view, visit http://gerrit.cloudera.org:8080/3563 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6b52ec7167999d6ac1d1c56a0ee9cef52dc1615e Gerrit-PatchSet: 3 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Henry Robinson <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-HasComments: Yes
