Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3201: headers and reservation logic for new buffer pool
......................................................................
Patch Set 22:
So these are the ways of layering things I looked at:
Current design:
+--------------------+
| Buffer handles (?) |
+-----------------------------------+
| Page handles |
+-----------------------------------+
| Pages (internal) w/ bookkeeping |
+-----------------------------------+
| Raw buffers (ptr/len) |
+-----------------------------------+
Exposed raw buffers (don't have any debuggability or other features for buffers
that we discussed).
+-----------------------------------+-------------------+
| Page handles | Allocate/Free |
+-----------------------------------+-------------------+
| Pages (internal descriptor) | |
+-----------------------------------+ |
| Raw buffers (ptr/len) |
+-------------------------------------------------------+
Detachable internal buffer descriptors:
+-----------------------------------+-------------------+
| Page handles | Buffer handles |
+-----------------------------------+-------------------+
| Pages (internal descriptor) | |
+-----------------------------------+ |
| Buffers (internal descriptor) |
+-------------------------------------------------------+
| Raw buffers (ptr/len) |
+-------------------------------------------------------+
Separate internal buffer descriptors:
+-----------------------------------+---------------------------------+
| Page handles | Buffer handles |
+-----------------------------------+---------------------------------+
| Pages (internal descriptor) | Buffers (internal descriptor) |
+---------------------------------------------------------------------+
| Raw buffers (ptr/len) |
+---------------------------------------------------------------------+
--
To view, visit http://gerrit.cloudera.org:8080/2569
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I35cc89e863efb4cc506657bfdaaaf633a10bbab6
Gerrit-PatchSet: 22
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Tim Armstrong <[email protected]>
Gerrit-Reviewer: Dan Hecht <[email protected]>
Gerrit-Reviewer: Marcel Kornacker <[email protected]>
Gerrit-Reviewer: Michael Ho
Gerrit-Reviewer: Mostafa Mokhtar <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-HasComments: No
