David Knupp has posted comments on this change. Change subject: IMPALA-3677: Write minidump on SIGUSR1 ......................................................................
Patch Set 8: Code-Review+1 (1 comment) I think someone else (other than me) needs to give a +2 because of the .cc file, yes? http://gerrit.cloudera.org:8080/#/c/3312/7/tests/custom_cluster/test_breakpad.py File tests/custom_cluster/test_breakpad.py: Line 117: def wait_for_num_processes(self, daemon, num_expected, timeout=60): > Yes, my original assumption was that the time we need to write all minidump Sounds good to me. -- To view, visit http://gerrit.cloudera.org:8080/3312 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I40149e48e391451de21a5c8bda18e2307fc89513 Gerrit-PatchSet: 8 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
