Dimitris Tsirogiannis has posted comments on this change. Change subject: Add Chef recipes for preparing an Impala dev machine ......................................................................
Patch Set 1: (27 comments) http://gerrit.cloudera.org:8080/#/c/3597/1/dev_tools/README.md File dev_tools/README.md: Line 3: A number of Chef cookbooks needed to setup an Impala dev machine. > spaces at end of lines Done Line 8: Run `sudo ./install.sh`. The script will download and install the chef binaries and it will execute > long lines Done http://gerrit.cloudera.org:8080/#/c/3597/1/dev_tools/cookbooks/README.md File dev_tools/cookbooks/README.md: Line 3: The main cookbook is `impala`. All other cookbooks in this directory are cookbooks that impala depends on. > long line, space at end of line Done http://gerrit.cloudera.org:8080/#/c/3597/1/dev_tools/cookbooks/chef-sugar/CHANGELOG.md File dev_tools/cookbooks/chef-sugar/CHANGELOG.md: > no licence for this dir? Done http://gerrit.cloudera.org:8080/#/c/3597/1/dev_tools/cookbooks/impala/CHANGELOG.md File dev_tools/cookbooks/impala/CHANGELOG.md: > Add a license to this dir? Done Line 8: - [your_name] - Initial release of impala > your_name_is_dimitris Done http://gerrit.cloudera.org:8080/#/c/3597/1/dev_tools/cookbooks/impala/README.md File dev_tools/cookbooks/impala/README.md: Line 3: This cookbook configures a machine for Impala development. > space at end of line Done http://gerrit.cloudera.org:8080/#/c/3597/1/dev_tools/cookbooks/impala/attributes/default.rb File dev_tools/cookbooks/impala/attributes/default.rb: Line 4: # All rights reserved - Do Not Redistribute > Please Apache license Done Line 9: # User options > spaces at end of lines Done Line 23: default['postgresql']['client']['packages'] = ["postgresql-client-#{default['postgresql']['version']}", "libpq-dev"] > long lines Done http://gerrit.cloudera.org:8080/#/c/3597/1/dev_tools/cookbooks/impala/recipes/default.rb File dev_tools/cookbooks/impala/recipes/default.rb: Line 7: # All rights reserved - Do Not Redistribute > Apache license Done http://gerrit.cloudera.org:8080/#/c/3597/1/dev_tools/cookbooks/impala/recipes/hbase.rb File dev_tools/cookbooks/impala/recipes/hbase.rb: Line 7: # All rights reserved - Do Not Redistribute > apache license Done Line 16: chmod 600 .ssh/authorized_keys > space at end of line Done http://gerrit.cloudera.org:8080/#/c/3597/1/dev_tools/cookbooks/impala/recipes/lzo.rb File dev_tools/cookbooks/impala/recipes/lzo.rb: Line 7: # All rights reserved - Do Not Redistribute > apache license Done Line 12: repository 'https://github.com/cloudera/hadoop-lzo.git' > I don't think we can include this. It is GPL. TBD http://gerrit.cloudera.org:8080/#/c/3597/1/dev_tools/cookbooks/impala/recipes/machine.rb File dev_tools/cookbooks/impala/recipes/machine.rb: Line 7: # All rights reserved - Do Not Redistribute > Apache license Done http://gerrit.cloudera.org:8080/#/c/3597/1/dev_tools/cookbooks/impala/recipes/packages.rb File dev_tools/cookbooks/impala/recipes/packages.rb: Line 7: # All rights reserved - Do Not Redistribute > apache license Done http://gerrit.cloudera.org:8080/#/c/3597/1/dev_tools/cookbooks/impala/recipes/postgres.rb File dev_tools/cookbooks/impala/recipes/postgres.rb: Line 7: # All rights reserved - Do Not Redistribute > apache license Done Line 19: psql -c "ALTER ROLE hiveuser WITH CREATEDB;" postgres || true > space at end of line Done http://gerrit.cloudera.org:8080/#/c/3597/1/dev_tools/cookbooks/impala/recipes/user.rb File dev_tools/cookbooks/impala/recipes/user.rb: Line 27: # Prepare the sudoers file > spaces at end of lines Done http://gerrit.cloudera.org:8080/#/c/3597/1/dev_tools/cookbooks/sudo/CHANGELOG.md File dev_tools/cookbooks/sudo/CHANGELOG.md: > license file? Done Line 1: v2.7.1 (2014-09-18) > Istructions say to use sudo to run script. Script downloads and installs su No this handles the updates to the sudoers file http://gerrit.cloudera.org:8080/#/c/3597/1/dev_tools/cookbooks/yum-epel/CHANGELOG.md File dev_tools/cookbooks/yum-epel/CHANGELOG.md: > license file? Done http://gerrit.cloudera.org:8080/#/c/3597/1/dev_tools/cookbooks/yum/CHANGELOG.md File dev_tools/cookbooks/yum/CHANGELOG.md: > license file? Done http://gerrit.cloudera.org:8080/#/c/3597/1/dev_tools/install.sh File dev_tools/install.sh: Line 5: # All rights reserved - Do Not Redistribute > apache license Done Line 15: sudo -u $USER sed -i "s/username = ''/username = '$USER'/" cookbooks/impala/attributes/default.rb > long line Done Line 24: curl -L https://www.opscode.com/chef/install.sh | bash > Can we download that here, istead of fetching it? Sorry, not following. What do you mean by download vs fetch? -- To view, visit http://gerrit.cloudera.org:8080/3597 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0699b7202eee3994c18b7bb13ed298e506cd615b Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-HasComments: Yes
