Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-3206: Enable codegen for AVRO_DECIMAL ......................................................................
IMPALA-3206: Enable codegen for AVRO_DECIMAL This change adds the missing switch statement in CodegenReadScalar() for AVRO_DECIMAL so that we will also codegen if an avro table contains AVRO_DECIMAL. With this change, the following query improves by 37.5%, going from 8s to 5s: select count(distinct l_linenumber), avg(l_extendedprice), max(l_discount), min(l_tax) from tpch15_avro.lineitem; This change also un-inlines BitUtil::ByteSwap() as the third argument 'len' is not compilation constant for all call sites. Change-Id: I51adf0c1ba76e055f31ccb0034a0d23ea2afb30e Reviewed-on: http://gerrit.cloudera.org:8080/3489 Reviewed-by: Michael Ho <[email protected]> Tested-by: Internal Jenkins --- M be/src/codegen/gen_ir_descriptions.py M be/src/exec/hdfs-avro-scanner.cc M be/src/util/CMakeLists.txt M be/src/util/bit-util-test.cc R be/src/util/bit-util.cc M be/src/util/bit-util.h M be/src/util/decimal-util.h M testdata/workloads/functional-query/queries/QueryTest/decimal_avro.test 8 files changed, 24 insertions(+), 11 deletions(-) Approvals: Michael Ho: Looks good to me, approved Internal Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/3489 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I51adf0c1ba76e055f31ccb0034a0d23ea2afb30e Gerrit-PatchSet: 6 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]>
