Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-3606: Fix Java NPE when trying to add an existing partition ......................................................................
IMPALA-3606: Fix Java NPE when trying to add an existing partition A NPE is also encountered when trying to drop a partition which does not exist. Currently, catalogd sends a response to impalad that contains a dummy TCatalogObject of type "TABLE" but contains nulls for all other fields. This causes a null pointer exception when impalad tries to access those null fields. The exception never gets exposed to the user as it was caught and ignored. In this case, the fix is that catalogd responds with an empty TCatalogUpdateResult that contains no dummy TCatalogObject objects. No testing was added since the NPE never gets exposed to the user. Change-Id: Ic829e8580c14ed88adf7a0d1571381526b18a206 Reviewed-on: http://gerrit.cloudera.org:8080/3324 Reviewed-by: Dimitris Tsirogiannis <[email protected]> Tested-by: Internal Jenkins --- M fe/src/main/java/com/cloudera/impala/service/CatalogOpExecutor.java 1 file changed, 12 insertions(+), 7 deletions(-) Approvals: Internal Jenkins: Verified Dimitris Tsirogiannis: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/3324 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic829e8580c14ed88adf7a0d1571381526b18a206 Gerrit-PatchSet: 6 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Michael Brown <[email protected]>
