Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-3778: Fix ASF packaging build ......................................................................
Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/3626/1/bin/impala-config.sh File bin/impala-config.sh: Line 74: echo $NO_THIRDPARTY > remove Done http://gerrit.cloudera.org:8080/#/c/3626/1/infra/python/deps/find_py26.py File infra/python/deps/find_py26.py: > It would be good to have a top level comment explaining what the file does. Done http://gerrit.cloudera.org:8080/#/c/3626/1/infra/python/deps/pip_download.py File infra/python/deps/pip_download.py: Line 71: hash_index = line.find('#') > Can you add a comment explaining the line syntax, either here or at the top Done -- To view, visit http://gerrit.cloudera.org:8080/3626 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibe5a743096cda2059bd330805d324983f6730e19 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: master Gerrit-Owner: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-HasComments: Yes
