Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-3778: Fix ASF packaging build ......................................................................
Patch Set 1: (2 comments) Yes, I ran the private build and test and the packaging job which passed. I will do so again after I get a +2. http://gerrit.cloudera.org:8080/#/c/3647/1/infra/python/deps/pip_download.py File infra/python/deps/pip_download.py: PS1, Line 90: A semi colon (";") specifies some additional condition for when the package > So what comes before the semi-colon? Done, added a comment. Yes, it follows this pip grammar: https://pip.pypa.io/en/stable/reference/pip_install/#requirement-specifiers PS1, Line 92: the installation script > What installation script? Specified the script. -- To view, visit http://gerrit.cloudera.org:8080/3647 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibe5a743096cda2059bd330805d324983f6730e19 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-HasComments: Yes
