Jian Wu has posted comments on this change.

Change subject: IMPALA-2328 Parquet scan should use min/max stats
......................................................................


Patch Set 1:

OK, 

 > I tried the patch and hitting some exceptions
 > 
 > #0  0x00007f8bbb197cc9 in __GI_raise (sig=sig@entry=6) at
 > ../nptl/sysdeps/unix/sysv/linux/raise.c:56
 > #1  0x00007f8bbb19b0d8 in __GI_abort () at abort.c:89
 > #2  0x00000000027dd644 in google::DumpStackTraceAndExit() ()
 > #3  0x00000000027d6add in google::LogMessage::Fail() ()
 > #4  0x00000000027d9406 in google::LogMessage::SendToLog() ()
 > #5  0x00000000027d65fd in google::LogMessage::Flush() ()
 > #6  0x00000000027d9eae in google::LogMessageFatal::~LogMessageFatal()
 > ()
 > #7  0x0000000001731516 in impala::PartitionedHashJoinNode::NextProbeRowBatch
 > (this=0x93e1b00, state=0x8b5b600, out_batch=0xd1e6520)
 > at 
 > /home/mmokhtar/workspace/Impala/be/src/exec/partitioned-hash-join-node.cc:755
 > #8  0x0000000001735a90 in impala::PartitionedHashJoinNode::GetNext
 > (this=0x93e1b00, state=0x8b5b600, out_batch=0xd1e6520,
 > eos=0x93e17e1)
 > at 
 > /home/mmokhtar/workspace/Impala/be/src/exec/partitioned-hash-join-node.cc:1031
 > #9  0x0000000001794c3b in impala::BlockingJoinNode::Open
 > (this=0x93e1680, state=0x8b5b600) at 
 > /home/mmokhtar/workspace/Impala/be/src/exec/blocking-join-node.cc:222
 > #10 0x000000000172bd24 in impala::PartitionedHashJoinNode::Open
 > (this=0x93e1680, state=0x8b5b600) at 
 > /home/mmokhtar/workspace/Impala/be/src/exec/partitioned-hash-join-node.cc:254
 > #11 0x0000000001794645 in impala::BlockingJoinNode::Open
 > (this=0x93e1200, state=0x8b5b600) at 
 > /home/mmokhtar/workspace/Impala/be/src/exec/blocking-join-node.cc:195
 > #12 0x000000000172bd24 in impala::PartitionedHashJoinNode::Open
 > (this=0x93e1200, state=0x8b5b600) at 
 > /home/mmokhtar/workspace/Impala/be/src/exec/partitioned-hash-join-node.cc:254
 > #13 0x000000000170accd in impala::PartitionedAggregationNode::Open
 > (this=0x8d64f00, state=0x8b5b600) at 
 > /home/mmokhtar/workspace/Impala/be/src/exec/partitioned-aggregation-node.cc:299
 > #14 0x000000000194e542 in impala::PlanFragmentExecutor::OpenInternal
 > (this=0x838a4d8) at 
 > /home/mmokhtar/workspace/Impala/be/src/runtime/plan-fragment-executor.cc:366
 > 
 > Can you please try running this query 
 > https://github.com/cloudera/Impala/blob/cdh5-trunk/testdata/workloads/tpch/queries/tpch-q10.test

OK, I'll look into it.

-- 
To view, visit http://gerrit.cloudera.org:8080/3623
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I91de1f4d0fb2a982d06cd344e41901e3bf3c2cea
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Jian Wu <jan.chou...@gmail.com>
Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com>
Gerrit-Reviewer: Jian Wu <jan.chou...@gmail.com>
Gerrit-Reviewer: Michael Ho <k...@cloudera.com>
Gerrit-Reviewer: Mostafa Mokhtar <mmokh...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>
Gerrit-HasComments: No

Reply via email to