Michael Ho has posted comments on this change. Change subject: IMPALA-3854: Fix use-after-free in HdfsTextScanner::Close() ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3630/1/be/src/exec/hdfs-text-scanner.cc File be/src/exec/hdfs-text-scanner.cc: Line 532: stream_->ReleaseCompletedResources(NULL, true); > I'm thinking that this change should not be unnecessary. In the commit msg We can still free up the boundary buffer and other resources associated with the stream here as they are not needed anymore. Calling context_->ReleaseCompletedResources(NULL, true) has the side effect of deleting the stream_ object too. -- To view, visit http://gerrit.cloudera.org:8080/3630 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia88f6285563ff669ae215af22ed2d45e5398adae Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-HasComments: Yes
