Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-3756: Fix wrong argument type in HiveStringsTest ......................................................................
IMPALA-3756: Fix wrong argument type in HiveStringsTest One of the tests in HiveStringsTest passed Text as input argument to TestHiveUdf() instead of String. It worked fine if the argument of UDFLength.evaluate() is of type Text but that doesn't seem to be the case in code coverage build. The fix is to call TestHiveUdf() with String and lets it cast the argument to the right type based on the signature of the UDF method. A test-only UdfExecutor ctor is also removed so we can exercise the actual ctor used by JNI calls from the BE. Change-Id: I662e6286dac601ae0e45f18545ef149724aa047e Reviewed-on: http://gerrit.cloudera.org:8080/3617 Reviewed-by: Michael Ho <[email protected]> Tested-by: Internal Jenkins --- M fe/src/main/java/com/cloudera/impala/hive/executor/UdfExecutor.java M fe/src/test/java/com/cloudera/impala/hive/executor/UdfExecutorTest.java 2 files changed, 83 insertions(+), 63 deletions(-) Approvals: Michael Ho: Looks good to me, approved Internal Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/3617 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I662e6286dac601ae0e45f18545ef149724aa047e Gerrit-PatchSet: 8 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]>
