Lars Volker has posted comments on this change. Change subject: IMPALA-3829: OpenSession() logs errors on valid configuration keys ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/3662/1/be/src/service/impala-hs2-server.cc File be/src/service/impala-hs2-server.cc: Line 620: // This is done by setting the 'impala.doas.user' Hive Server 2 > Done Nit: this looks more like 80 chars now. Can you wrap it to 90? http://gerrit.cloudera.org:8080/#/c/3662/1/tests/hs2/test_hs2.py File tests/hs2/test_hs2.py: Line 29: class TestHS2(HS2TestSuite): > test_open_session_query_options() method was only meant to test that normal Yes, retrieving the session state seems too much, and it might come with security implications, too. Given the code is already covered in the tests you mentioned I think it should be fine. -- To view, visit http://gerrit.cloudera.org:8080/3662 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifa9b823abc39ba9809a35a6f0844fa3436f1e025 Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Attila Jeges <[email protected]> Gerrit-Reviewer: Attila Jeges <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-HasComments: Yes
