Michael Ho has posted comments on this change. Change subject: IMPALA-3854: Fix use-after-free in HdfsTextScanner::Close() ......................................................................
Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/3630/4//COMMIT_MSG Commit Message: PS4, Line 23: ClearlStreams > typo Fixed. http://gerrit.cloudera.org:8080/#/c/3630/4/be/src/exec/hdfs-text-scanner.cc File be/src/exec/hdfs-text-scanner.cc: PS4, Line 194: decompression_type_ > it looks like this is only set in ProcessSplit() if we found a tuple starti Actually, that's a good point. The default value of decompression_type_ is THdfsCompression::NONE so in the case in which no tuple is found in the scan range, we may mistakenly account it towards the wrong compression type. Given that we will keep the stream object alive till the end now, we can go ahead and restore the old code here. -- To view, visit http://gerrit.cloudera.org:8080/3630 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia88f6285563ff669ae215af22ed2d45e5398adae Gerrit-PatchSet: 4 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-HasComments: Yes
