Michael Brown has posted comments on this change.

Change subject: IMPALA-3892: qgen: always run Impala with 
-convert_legacy_hive_parquet_utc_timestamps=true
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/3713/1/tests/comparison/leopard/impala_docker_env.py
File tests/comparison/leopard/impala_docker_env.py:

PS1, Line 189: "-convert_legacy_hive_parquet_utc_timestamps=true"
> I don't have particular insight into the discrepancies between impala and p
Done. There are 86 "no spaces around = in keyword args" violations in this 
file. I only fixed this one to keep the diff small.


PS1, Line 189: "-convert_legacy_hive_parquet_utc_timestamps=true"
> Also, the line is longer than 90 characters.
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/3713
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6e0a14780dd9bcc18285f2857625fd3ec1c34913
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Michael Brown <[email protected]>
Gerrit-Reviewer: David Knupp <[email protected]>
Gerrit-Reviewer: Michael Brown <[email protected]>
Gerrit-Reviewer: Taras Bobrovytsky <[email protected]>
Gerrit-HasComments: Yes

Reply via email to