Alex Behm has posted comments on this change. Change subject: IMPALA-3764: fuzz test HDFS scanners ......................................................................
Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/3448/5/tests/query_test/test_scanners.py File tests/query_test/test_scanners.py: Line 649: random_seed = os.environ.get("SCANNER_FUZZ_SEED") or time.time() > We can discuss this a bit in person but my feeling is that it's better to u Agree better to discuss f2f. There's a tradeoff between coverage and build stability. It is my impression that we fundamentally cannot handle certain types of file corruption, so I'm reluctant to add random failures in our regular build+test runs. I'm happy to discuss and be convinced otherwise. -- To view, visit http://gerrit.cloudera.org:8080/3448 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I50cf43195a7c582caa02c85ae400ea2256fa3a3b Gerrit-PatchSet: 5 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
