Tim Armstrong has posted comments on this change. Change subject: IMPALA-3881: Add DataTables 1.10.12 to www/ ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/3679/1/www/datatables.js File www/datatables.js: It doesn't look we check in non-minimised files for the other dependencies like JQuery. I'm fine with checking this in but just wanted to note the inconsistency. Line 21: * Released under the MIT license I think we should check in actual license text, since all we have here is the link. -- To view, visit http://gerrit.cloudera.org:8080/3679 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic1001870a50fbf21efed29a446815436da1a36fa Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Henry Robinson <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
