Tim Armstrong has posted comments on this change. Change subject: IMPALA-3227: generate test TPC data sets during data load ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/3761/2//COMMIT_MSG Commit Message: PS2, Line 7: IMPALA-3227 > Can you add in this commit message that those tarballs are not available ex Done http://gerrit.cloudera.org:8080/#/c/3761/2/bin/load-data.py File bin/load-data.py: PS2, Line 160: if os.path.exists(dataset_preload_script) > Why do you think the script should not know that? load-data.py is meant to be a generic data-loading script that works for any workload that has the appropriate files in the appropriate places - coding specific logic about the tpc data sets would be out of place. I'm happy to do additional testing if you have concerns. -- To view, visit http://gerrit.cloudera.org:8080/3761 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieccfbd7d8d4a91bffddbe35abb7f5572e71a71cf Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
