Tim Armstrong has posted comments on this change. Change subject: IMPALA-1112: Remove some unncessary code from cross-compilation ......................................................................
Patch Set 2: Code-Review+1 (2 comments) Thanks for the cleanup http://gerrit.cloudera.org:8080/#/c/3793/2//COMMIT_MSG Commit Message: Line 16: cross-compilation as they won't benefit from it. Also the Uuid() function. http://gerrit.cloudera.org:8080/#/c/3793/2/be/src/exprs/utility-functions.cc File be/src/exprs/utility-functions.cc: Line 39: StringVal UtilityFunctions::GenUuid(FunctionContext* ctx) { Maybe it's worth commenting why this isn't cross-compiled. I don't think it's immediately obvious. -- To view, visit http://gerrit.cloudera.org:8080/3793 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I543809c69da0b4085a0e299b91cd550b274c46af Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
