David Knupp has posted comments on this change. Change subject: IMPALA-1683: Allow REFRESH on a single partition ......................................................................
Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/3385/9/tests/metadata/test_refresh_partition.py File tests/metadata/test_refresh_partition.py: PS9, Line 27: class ImpalaTableWrapper(object): > this seems useful! I wonder if there's a better place to put it so that oth So, if we were to make something like this class generally available, it should probably go into tests/conftest.py. (Note that this wrapper was taken from tests/metadata/test_hms_integration.py, and there are a few other wrappers there like it.) In conftest.py, there's also "unique_database," which does something very similar to this context manager, but it has been written somewhat differently -- as a pytest fixture. So we might need to decide upon a standard approach for making these sorts of resources generally available. What would you say to submitting this code as is, and then opening an enhancement ticket against the test framework? We can put in a note to refactor this module as well as test_hms_integration once that enhancement has been written? (Going to ping mikeb to weigh in as well.) -- To view, visit http://gerrit.cloudera.org:8080/3385 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4bf5dd630f2e175be5800187bbf9337c91f82bd8 Gerrit-PatchSet: 9 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-HasComments: Yes
