Tim Armstrong has posted comments on this change. Change subject: IMPALA-3611: track unused Disk IO buffer memory ......................................................................
Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/3246/10/be/src/runtime/disk-io-mgr.h File be/src/runtime/disk-io-mgr.h: Line 779: MemTracker* mem_tracker, ScanRange* range, char* buffer, int64_t buffer_size); > let's group GetBufferDesc and GetFreeBuffer decls together, and group Retur Did the grouping, but not doing the rename: unfortunately they're not actually totally analogous because of the way cached buffers are handled. GetFreeBuffer() never returns a cached buffer, but ReturnBuffer() handles cached buffer. -- To view, visit http://gerrit.cloudera.org:8080/3246 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8777cf76f04d34a46f53d53005412e0f1d63b5b7 Gerrit-PatchSet: 10 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
