Tim Armstrong has posted comments on this change.

Change subject: IMPALA-1619, IMPALA-3018: Address various small memory 
allocation related bugs
......................................................................


Patch Set 1:

It would be nice to also include checking for the result of malloc in 
buffered-block-mgr and disk-io-mgr*. I believe in both those cases it can throw 
a bad_alloc exception. We could also do that in a follow-up patch.

* although that will probably conflict with my patch that's in flight.

-- 
To view, visit http://gerrit.cloudera.org:8080/3807
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6eb9a4472a65cf68edb0323b13d745277ead2e1d
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Ho <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-HasComments: No

Reply via email to