Michael Ho has posted comments on this change. Change subject: IMPALA-3629: Codegen TransferScratchTuples() in hdfs-parquet-scanner ......................................................................
Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/3774/3/be/src/exec/hdfs-parquet-scanner-ir.cc File be/src/exec/hdfs-parquet-scanner-ir.cc: PS3, Line 44: if (tuple_size == 0) { > My thought was that tuple_size is a constant most of the function should be Yes, it would be good to not cross-compile the body of this if-statement if that's not too hard to do. PS3, Line 61: while (scratch_tuple != scratch_tuple_end) { > I thought about that but I'm not sure there's much gain once we prune out t That's a good point. One way to work around it is to pass the start and end of the iterator explicitly as arguments but it may not be worth it if the code ends up being too complicated. -- To view, visit http://gerrit.cloudera.org:8080/3774 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic327e437c7cd2b3f92cdb11c1e907bfee2d44ee8 Gerrit-PatchSet: 3 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
