Marcel Kornacker has posted comments on this change. Change subject: IMPALA-3905: Add HdfsScanner::GetNext() interface and implementation for Parquet. ......................................................................
Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/3801/2/be/src/exec/hdfs-parquet-scanner.cc File be/src/exec/hdfs-parquet-scanner.cc: Line 302: Status HdfsParquetScanner::GetNext(RowBatch* row_batch, bool* eos) { hm, it would still be nice to check that if this is getting called from outside, add_batches_to_queue is false. private GetNextAux(), and have the public GetNext() perform the check? http://gerrit.cloudera.org:8080/#/c/3801/2/be/src/exec/hdfs-scanner.h File be/src/exec/hdfs-scanner.h: Line 109: /// If 'add_batches_to_queue' is true the caller most use ProcessSplit() and not must (call) Line 132: /// This function should only return on error or end of scan range. you can't call this if add_batches_to_queue was false, right? point that out. same for other functions in this class. -- To view, visit http://gerrit.cloudera.org:8080/3801 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iab50770bac05afcda4d3404fb4f53a0104931eb0 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-HasComments: Yes
