Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3857: KuduScanNode race on returning "optional" threads ......................................................................
Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/3798/1/be/src/exec/kudu-scan-node.cc File be/src/exec/kudu-scan-node.cc: Line 427: scan_ranges_complete_counter()->Add(1); > we should probably only do this at line 422. i.e. not do it if we stopped e I don't think we want to do it on 422 because there may be many batches per scan range. However, I can do this only when eos. Line 432: DCHECK_NOTNULL(initial_range); > DCHECK(initial_ranges != NULL); Done PS1, Line 451: If this isn't the last scanner thread, return early > rather than restating what the code does, let's explain why: Done PS1, Line 452: checking optional_exceeded > this comment doesn't seem correct given that optional_exceeded() call isn't Yes this is confusing. I think it's not necessary anyway with the first sentence. http://gerrit.cloudera.org:8080/#/c/3798/1/be/src/exec/kudu-scan-node.h File be/src/exec/kudu-scan-node.h: Line 171: Status ProcessRange(KuduScanner* scanner, const TKuduKeyRange* key_range); > I think this deserves it's own comment, and you could move some of the cont I meant to add one, thanks. -- To view, visit http://gerrit.cloudera.org:8080/3798 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I22adf2109b43b1b37d9a597de85e063431dff155 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-HasComments: Yes
