Alex Behm has posted comments on this change. Change subject: IMPALA-3861: Fix BetweenPredicate.clone() to preserve Expr reference structure. ......................................................................
Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/3804/2/fe/src/main/java/com/cloudera/impala/analysis/BetweenPredicate.java File fe/src/main/java/com/cloudera/impala/analysis/BetweenPredicate.java: PS2, Line 132: private void setRewrittenPredicate() > Where is this function used? Sorry forgot to delete. Not needed. Removed. http://gerrit.cloudera.org:8080/#/c/3804/2/fe/src/test/java/com/cloudera/impala/analysis/AnalyzeSubqueriesTest.java File fe/src/test/java/com/cloudera/impala/analysis/AnalyzeSubqueriesTest.java: PS2, Line 487: AnalyzesOk > Why in comments and not an AnalysisError? Good point, that makes much more sense. Done. http://gerrit.cloudera.org:8080/#/c/3804/2/testdata/workloads/functional-planner/queries/PlannerTest/subquery-rewrite.test File testdata/workloads/functional-planner/queries/PlannerTest/subquery-rewrite.test: PS2, Line 1846: t2.test_id between t1.tinyint_col and t1.int_col > Can you also add one or more cases with more "interesting" exprs in the bet Thank you for this comment! It helped me discover more bugs with correlated between predicates. I completely reworked the solution to be more robust. I modified the tests to include several complicated between predicates. -- To view, visit http://gerrit.cloudera.org:8080/3804 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0838b30444ed9704ce6a058d30718a24caa7444a Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Internal Jenkins Gerrit-HasComments: Yes
