Bikramjeet Vig has posted comments on this change. Change subject: IMPALA-1683: Allow REFRESH on a single partition ......................................................................
Patch Set 12: Code-Review+2 (9 comments) Carrying forward Henry's +2. http://gerrit.cloudera.org:8080/#/c/3385/11//COMMIT_MSG Commit Message: PS11, Line 32: . > , Done PS11, Line 33: This > this (part of previous sentence). Done http://gerrit.cloudera.org:8080/#/c/3385/11/fe/src/main/java/com/cloudera/impala/catalog/CatalogServiceCatalog.java File fe/src/main/java/com/cloudera/impala/catalog/CatalogServiceCatalog.java: Line 1178: throws CatalogException { > indentation is wrong here Done http://gerrit.cloudera.org:8080/#/c/3385/11/fe/src/main/java/com/cloudera/impala/catalog/HdfsTable.java File fe/src/main/java/com/cloudera/impala/catalog/HdfsTable.java: Line 1943: * 'hmsPartition'. > Comment what happens if oldPartition is null (the partition is added, with Done http://gerrit.cloudera.org:8080/#/c/3385/11/tests/metadata/test_refresh_partition.py File tests/metadata/test_refresh_partition.py: Line 1: # Copyright (c) 2015 Cloudera, Inc. All rights reserved. > Remove this line - copyright belongs to ASF now. Done PS11, Line 56: rows.pop() > tiny cleanup: just do rows[:-1] on line 61 Done Line 83: 'alter table %s add partition (y = 333, z = 5309)' % table_name) > choose a consistent style for writing partition specs. spaces around '=' or Done Line 198: self.client.execute("alter table %s add partition (year=2010, month =1)" % > month=1 Done Line 258: self.client.execute("refresh %s partition (year=2010, month =2)" % table_name) > month=2 Done -- To view, visit http://gerrit.cloudera.org:8080/3385 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4bf5dd630f2e175be5800187bbf9337c91f82bd8 Gerrit-PatchSet: 12 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-HasComments: Yes
