Dan Hecht has posted comments on this change. Change subject: IMPALA-3764,3914: fuzz test HDFS scanners and fix parquet bugs found ......................................................................
Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/3448/9/be/src/util/dict-encoding.h File be/src/util/dict-encoding.h: Line 171: if (UNLIKELY(buffer_len == 0)) return Status("Dictionary cannot be 0 bytes"); > My thought was that negative lengths are clearly nonsensical, but the fact Since buffer_len == 0 is an invalid dictionary, I think we should just make it an invariant that the caller shouldn't try to create such a thing. But I don't feel that strongly about it so okay to leave as-is if you prefer. -- To view, visit http://gerrit.cloudera.org:8080/3448 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I50cf43195a7c582caa02c85ae400ea2256fa3a3b Gerrit-PatchSet: 9 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: David Knupp <dkn...@cloudera.com> Gerrit-Reviewer: Taras Bobrovytsky <tbobrovyt...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
