Please do not commit to the "Impala" gerrit project any more. It is stale and it will remain stale.
Use "Impala-ASF" for asf and use private jenkins for private github. Public github (corresponding to public gerrit project "Impala") should be stale at the moment. Please see our branching document (private to Clouders) and http://www.google.com/url?q=http%3A%2F%2Fmail-archives.apache.org%2Fmod_mbox%2Fincubator-impala-dev%2F201607.mbox%2F%253CCAC-pSX2sHyqsoxGCCKrqmQbo-jjWdP6CMGoTU_1snuQVkDVg_w%40mail.gmail.com%253E&sa=D&sntz=1&usg=AFQjCNFyYa3BsqALZuEvxDzgAV5l4P_evQ On Tue, Aug 2, 2016 at 6:50 AM, Bharath Vissapragada <[email protected]> wrote: > This commit has been cherry-picked like any other commit [1]. I pushed it > to gerrit bypassing the code review. Per my understanding, gerrit checks > the "Change-Id" field and sees if there is an existing review for that id > and branch and sends out a message. Once it is committed to the gerrit > remote, it is replicated to the git remote automatically (we have git > replication scripts in place for that). So I think this message is normal. > Please let me know if anyone thinks otherwise. > > [1] https://github.com/cloudera/Impala/commits/cdh5-trunk > > On Tue, Aug 2, 2016 at 7:06 PM, Lars Volker <[email protected]> wrote: > >> I'm not sure at all what's supposed to happen with outdated changes in >> cdh5-trunk. Probably this one should have been transported just as any >> other change merged into asf/master. Maybe your transport did the right >> thing and Gerrit picked it up wrongly? Did you sync git repositories or >> Gerrit instances? >> >> On Aug 2, 2016 14:02, "Bharath Vissapragada" <[email protected]> >> wrote: >> >>> Oops. I was sync'ing gerrit/cdh5-trunk and asf/master. They became >>> off-sync after the move to asf. Shouldn't this be cherry-picked ? >>> >>> On Tue, Aug 2, 2016 at 5:27 PM, Lars Volker <[email protected]> wrote: >>> >>>> Hi Bharath, >>>> >>>> Did you mean to merge this? Or did I misinterpret the Gerrit mail? >>>> >>>> Cheers, Lars >>>> >>>> On Aug 2, 2016 12:55, "Bharath Vissapragada (Code Review)" < >>>> [email protected]> wrote: >>>> >>>>> Bharath Vissapragada has submitted this change and it was merged. >>>>> >>>>> Change subject: IMPALA-2979: Fix scheduling on remote hosts >>>>> ...................................................................... >>>>> >>>>> >>>>> IMPALA-2979: Fix scheduling on remote hosts >>>>> >>>>> Also fixes: IMPALA-2400, IMPALA-3043 >>>>> >>>>> This change fixes scheduling scan-ranges on remote hosts by adding >>>>> remote backend selection capability to SimpleScheduler. Prior to this >>>>> change the scheduler would try to select a local backend even when >>>>> remote scheduling was requested. >>>>> >>>>> This change also allows pseudo-randomized remote backend selection to >>>>> prevent convoying, which could happen when different independent >>>>> schedulers had the same internal state, e.g. after a cluster restart. To >>>>> enable the new behavior set the query option SCHEDULE_RANDOM_REPLICA to >>>>> true. >>>>> >>>>> This change also fixes IMPALA-2400: Unpredictable locality behavior >>>>> for reading Parquet files >>>>> >>>>> This change also fixes IMPALA-3043: SimpleScheduler does not handle >>>>> hosts with multiple IP addresses correctly >>>>> >>>>> This change also does some clean-up in scheduler.h and >>>>> simple-scheduler.{h,cc}. >>>>> >>>>> Change-Id: I044f83806fcde820fcb38047cf6b8e780d803858 >>>>> Reviewed-on: http://gerrit.cloudera.org:8080/3771 >>>>> Reviewed-by: Lars Volker <[email protected]> >>>>> Reviewed-by: Sailesh Mukil <[email protected]> >>>>> Tested-by: Internal Jenkins >>>>> (cherry picked from commit 0ad935b63c23029bd4cac4beefde6b3b7c0e322b) >>>>> --- >>>>> M be/src/scheduling/scheduler.h >>>>> M be/src/scheduling/simple-scheduler-test.cc >>>>> M be/src/scheduling/simple-scheduler.cc >>>>> M be/src/scheduling/simple-scheduler.h >>>>> M be/src/service/query-options.cc >>>>> M be/src/service/query-options.h >>>>> M common/thrift/ImpalaInternalService.thrift >>>>> M common/thrift/ImpalaService.thrift >>>>> M fe/src/main/java/com/cloudera/impala/analysis/TableRef.java >>>>> M fe/src/test/java/com/cloudera/impala/analysis/AnalyzeStmtsTest.java >>>>> M fe/src/test/java/com/cloudera/impala/analysis/ParserTest.java >>>>> M fe/src/test/java/com/cloudera/impala/analysis/ToSqlTest.java >>>>> 12 files changed, 984 insertions(+), 489 deletions(-) >>>>> >>>>> >>>>> >>>>> -- >>>>> To view, visit http://gerrit.cloudera.org:8080/2200 >>>>> To unsubscribe, visit http://gerrit.cloudera.org:8080/settings >>>>> >>>>> Gerrit-MessageType: merged >>>>> Gerrit-Change-Id: I044f83806fcde820fcb38047cf6b8e780d803858 >>>>> Gerrit-PatchSet: 33 >>>>> Gerrit-Project: Impala >>>>> Gerrit-Branch: cdh5-trunk >>>>> Gerrit-Owner: Lars Volker <[email protected]> >>>>> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> >>>>> Gerrit-Reviewer: Internal Jenkins >>>>> Gerrit-Reviewer: Lars Volker <[email protected]> >>>>> Gerrit-Reviewer: Marcel Kornacker <[email protected]> >>>>> Gerrit-Reviewer: Matthew Jacobs <[email protected]> >>>>> Gerrit-Reviewer: Mostafa Mokhtar <[email protected]> >>>>> Gerrit-Reviewer: Sailesh Mukil <[email protected]> >>>>> Gerrit-Reviewer: anujphadke <[email protected]> >>>>> >>>> >>> >>> >>> -- >>> Thanks, >>> Bharath >>> >> > > > -- > Thanks, > Bharath
