Jim Apple has posted comments on this change. Change subject: IMPALA-3153: Incorrect behaviour around slash escaping single quotes ......................................................................
Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/3335/2//COMMIT_MSG Commit Message: PS2, Line 7: IMPALA Please see the comment on this bug first - what does the SQL standard say is the correct behavior? PS2, Line 9: sub process What is a "sub process"? http://gerrit.cloudera.org:8080/#/c/3335/2/fe/src/main/java/com/cloudera/impala/analysis/StringLiteral.java File fe/src/main/java/com/cloudera/impala/analysis/StringLiteral.java: Line 79: str.insert(pos + (count++), '\\'); This seems more complex than iterating over the strong one character at a time, and it also might have quadratic complexity if StringBuilder.insert takes linear time. -- To view, visit http://gerrit.cloudera.org:8080/3335 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I002f75f3330ee319d82213331a5a046ecf198189 Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Feng Guangyuan <[email protected]> Gerrit-Reviewer: Feng Guangyuan <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-HasComments: Yes
