Tim Armstrong has posted comments on this change. Change subject: IMPALA-3945: Forbid create text table with nonsensical delimiter combinations. ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3839/1/tests/query_test/test_delimited_text.py File tests/query_test/test_delimited_text.py: Line 56: def test_break_row_format_restriction(self, vector, unique_database): We actually already have test coverage for this in AnalyzeDDLTest.TestCreateTable(), so this new test shouldn't be necessary. You'll Just need to update the existing test to reflect the new behaviour. -- To view, visit http://gerrit.cloudera.org:8080/3839 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I836b45f930e680ea03274405b90b1ee14822152b Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Yuanhao Luo <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
