Dan Hecht has posted comments on this change. Change subject: IMPALA-3611: track unused Disk IO buffer memory ......................................................................
Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/3799/6/be/src/runtime/disk-io-mgr.cc File be/src/runtime/disk-io-mgr.cc: Line 364: } this is fine but when do we construct without calling Init()? http://gerrit.cloudera.org:8080/#/c/3799/6/be/src/runtime/disk-io-mgr.h File be/src/runtime/disk-io-mgr.h: Line 280: bool is_cached_; when is this not equivalent to scan_range_->cached_buffer_ != NULL? Or is it that sometimes we don't have a scan_range_ at the point we need to check for is_cached()? (Though why does that happen?) -- To view, visit http://gerrit.cloudera.org:8080/3799 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8777cf76f04d34a46f53d53005412e0f1d63b5b7 Gerrit-PatchSet: 6 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
