Tim Armstrong has posted comments on this change. Change subject: IMPALA-3790: Fix admission control flaky stress test ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/3861/1/tests/custom_cluster/test_admission_controller.py File tests/custom_cluster/test_admission_controller.py: Line 336: num_queries = None This value of num_queries is dead, since we exit early on the only branch where it's not assigned. Line 347: return I find the control flow here confusing and I think it will be error-prone if anyone tries to add new constraints in the future. Why not just set num_queries = None here and check if num_queries is None below before adding the constraint. That makes the control flow more consistent between different configurations. -- To view, visit http://gerrit.cloudera.org:8080/3861 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id62f7603f1174aa02469c6ca57513c3f1fa1e221 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
