Kathy Sun has posted comments on this change. Change subject: draft version -- not completed yet ......................................................................
Patch Set 2: Oh Tim, I Thank you so much! I didn't see your review before I upload the second patch. Please don't see it until next patch. I'll work on the problems you pointed to. btw, since it is a draft, I didn't take care of code style at all :O. I'm sorry... Would you please focus on design at current stage? I don't want to waste your time on this... I would definitely pay attention to code styles though. I haven't compile it as well since there is still parts in doubt. In the second patch I mainly solve the problem of the two point we discussed. And I do want to talk face to face about my timeline... I feel I'm slower than expected. Thank you so much on reviewing my not-so-prepared code! It must be painful (>_<) -- To view, visit http://gerrit.cloudera.org:8080/3863 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7adbeb45220c468e43b424d70c30b952f6cec2cd Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Kathy Sun <kathy....@cloudera.com> Gerrit-Reviewer: Kathy Sun <kathy....@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: No