Dan Hecht has posted comments on this change. Change subject: IMPALA-3946: fix MemPool integrity issues with empty chunks ......................................................................
Patch Set 4: Code-Review+2 (4 comments) http://gerrit.cloudera.org:8080/#/c/3838/4/be/src/runtime/mem-pool.cc File be/src/runtime/mem-pool.cc: PS4, Line 106: free chunk what is a "free chunk"? One with allocated_bytes == 0? not your change, but we don't actually define that term AFAICT. PS4, Line 130: a big enough ? PS4, Line 143: we didn't change any state, this comment seems to be only interesting due to how the old code worked, but reading the current code (and ignoring the historical code) it doesn't seem necessary to explain this. PS4, Line 153: We didn't change any state same. and besides, we did change state but we already un-did it (memtracker release). -- To view, visit http://gerrit.cloudera.org:8080/3838 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I03ad12e5b2b63cbb55e5c52562416d73a4bd9346 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
