Tim Armstrong has posted comments on this change. Change subject: IMPALA-3764,3914: fuzz test HDFS scanners and fix parquet bugs found ......................................................................
Patch Set 6: You can look at the 5->6 delta to see the changes. Logically the changes are: * Error handling in GetVlqInt() * Negative row counts in metadata * when the data page was empty, we ended up calling dict_decoder_.GetValue() without calling dict_decoder_.SetData(), which DCHECKS. The fix is to remove the special code paths for data_size = 0 and always call SetData() (which returns an error status in that case). * don't fail the test if it hits a memory limit -- To view, visit http://gerrit.cloudera.org:8080/3833 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I50cf43195a7c582caa02c85ae400ea2256fa3a3b Gerrit-PatchSet: 6 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: No
