Jim Apple has posted comments on this change. Change subject: IMPALA-2581: LIMIT can be propagated down into some aggregations ......................................................................
Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/3822/4/fe/src/main/java/com/cloudera/impala/analysis/AggregateInfoBase.java File fe/src/main/java/com/cloudera/impala/analysis/AggregateInfoBase.java: Line 182: public boolean isPreaggLimitable() { > I think this optimization will produce a wrong plan for queries like this o How would you feel about adding the no-HAVING-clause restriction here and adding a TODO or a JIRA about moving the HAVING into pre-agg? -- To view, visit http://gerrit.cloudera.org:8080/3822 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I59c5b7af7a73ccdbc5496b28eacb9b6859d202bc Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Jim Apple <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
